Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN15h: token errors, when the library can renew, result in DISCONNEC… #439

Closed
wants to merge 45 commits into from
Closed

RTN15h: token errors, when the library can renew, result in DISCONNEC… #439

wants to merge 45 commits into from

Conversation

paddybyers
Copy link
Member

mattheworiordan and others added 30 commits March 28, 2018 21:43
@mattheworiordan @paddybyers
spec: Reject invalid authCallback / authUrl content
b1c09bf 
We have seen authUrl retrieving HTML files greater than 500kb in size which should have been rejected due to the content type, but also because of the size.
@mattheworiordan @paddybyers
spec: authCallback can take a JSON-like object
1acf1e4
@mattheworiordan @paddybyers
spec: Consistent spec reference formatting
55642a2
@mattheworiordan @paddybyers
api: Add details on authUrl / authCallback payload restrictions
47606aa
@mattheworiordan @paddybyers
spec: Prefer JSON-encodeable
92bd442 
See #203 (comment)
@mattheworiordan @paddybyers
spec: Describe how TokenDetails are detected
593d983
@SimonWoolf @paddybyers
Be explicit about failure conditions vs result in realtime vs rest libs
2f99cda
@mattheworiordan @paddybyers
EventEmitter emit spec update (#240)
0805df1 
* spec: Clarify EventEmitter emit behaviour when new listeners registered

* spec: Update to reflect Simon’s suggested wording
@SimonWoolf @paddybyers
Allow clientoptions.token to be a string, tokendetails, or tokenrequest
8cc09fd
@SimonWoolf @paddybyers
Add spec item for transportParams overriding default params
c571644
@SimonWoolf @paddybyers
Clarify RSA10e (Auth#authorize requesting tokens)
9f3bc39 
Add missing token and tokenDetails properties to authOptions

Clarify TokenDetails
@mattheworiordan @paddybyers
spec: Send exceptions to ably error reporting service
f20b888 
In order to improve libraries for all customers, we are proposing that all libraries send unhandled exceptions to our central error reporting service.
@mattheworiordan @paddybyers
spec: Href and source for ErrorInfo
e1ba837 
See ably/ideas#142 and https://github.com/ably/ably-common/pull/21/files
@mattheworiordan @paddybyers
spec: Address feedback
1af4d39
@mattheworiordan @paddybyers
spec: New ErrorInfo attributes are optional
52e8947
@mattheworiordan @paddybyers
spec: Replace source with cause
dce7bb8 
See #242
@SimonWoolf @paddybyers
Clarify spec on client auth failures
584eaad
@paddybyers
Support for the Sentry exception reporting service is optional in 1.1
7ed0beb
@paddybyers
Include extras in PresenceMessage and associated API
7eed9c0
@paddybyers
Clarify definition of JSON-encodable
ea5fa51
@paddybyers
Add explicit requirement for robustness principle for forwards compat…
f679b18 
…ibility
@tcard @paddybyers
Add spec for PushChannel.
7248dac
@tcard @paddybyers
Minor fixes, clarifications and omissions in push spec.
7dfb958
@mezis @paddybyers
Fixes some iOS Swift docs (handles renames)
4e581db
@paddybyers
Add some comments on device authentication for push operations (draft)
45184af
@paddybyers
Updates to reflect changes in device authentication for push
701ca1c
@funkyboy @paddybyers
Change RHS to RSH
4eda374 
As per Slack chat https://ably-real-time.slack.com/archives/C030C5YLY/p1521742090000377
@funkyboy @paddybyers
Relabel push channels section with RSH7
13fcdb8
@funkyboy @paddybyers
Reorder sections by label
567a1ee
@paddybyers
Correct description of device id generation
46e780a
paddybyers and others added 13 commits March 29, 2018 10:15
@paddybyers
Minor spec corrections
459bfd0
@paddybyers
Merge pull request #411 from ably/spec-extensible-decoding
032fa07 
Explicitly require liberal decoding for forwards compatibility
@paddybyers
Merge pull request #410 from ably/spec-clarify-json-encodable
3975f69 
Clarify the meaning of "JSON-encodable"
@paddybyers
Merge pull request #408 from ably/spec-sentry-optional
6d83887 
Make support for sentry optional
@paddybyers
Merge pull request #399 from ably/integration-push
1a73585 
Push notifications spec updates
@paddybyers
Add requirements for JWT support
206e801
@paddybyers
Minor corrections following feedback
74cc4c5
@funkyboy
Add missing URL for JWT
7e97612
@paddybyers
Add 40106 error code for no credentials; clarify possibly authURL res…
a5abc73 
…ponse content types
@paddybyers
Merge pull request #420 from ably/add-jwt
30d6207 
Add requirements for JWT support
@funkyboy
RSC3d -> RSA3d
6c021da
@funkyboy
Merge pull request #438 from ably/fix-RSC3d-ref
ccc022f 
RSC3d -> RSA3d
@paddybyers
RTN15h: token errors, when the library can renew, result in DISCONNEC…
49a57c0 
…TED, not FAILED
@paddybyers paddybyers mentioned this pull request Jun 5, 2018
Merged
12 tasks
SimonWoolf
SimonWoolf approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mattheworiordan
mattheworiordan approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimonWoolf
Copy link
Member

integration-spec-1-1

(btw, we already have master-1-1 acting as an integration branch for the 1.1 spec, why do we have integration-spec-1-1 too? neither is a parent of the other)

@paddybyers
Copy link
Member Author

(btw, we already have master-1-1 acting as an integration branch for the 1.1 spec, why do we have integration-spec-1-1 too? neither is a parent of the other)

integration-spec-1-1 was created as the authoritative integration branch because master-1-1 had things in it that weren't actually spec changes (eg b276d76). I do remember a discussion about that with Matt at the time but I can't remember if there was also a plan to merge those non-spec commits.

However, we should tidy things up and decide if there's anything in there that's got lost and needs to be dealt with.

@mattheworiordan
Copy link
Member

integration-spec-1-1 was created as the authoritative integration branch because master-1-1 had things in it that weren't actually spec changes (eg b276d76).

@paddybyers the only reason it has non spec 1.1 commits is because master-1-1 has not been rebased, see 2d11e3e#diff-04c6e90faac2675aa89e2176d2eec7d8 which is on master.

I think we should rebase and not have two separate branches for the same thing.

@paddybyers
Copy link
Member Author

I think we should rebase and not have two separate branches for the same thing.

I think that means rebase integration-spec-1-1, delete master-1-1 and ensure that all non-spec commits are in master. You're ok for me to do that?

@mattheworiordan
Copy link
Member

Well I personally would have simply rebased master-1-1 given it's used by the running 1.1 PR we've had open for a very long time.

@funkyboy funkyboy mentioned this pull request Jun 6, 2018
Closed
@SimonWoolf SimonWoolf force-pushed the integration-spec-1-1 branch from ccc022f to f8fe081 Compare June 19, 2018 16:57
@paddybyers paddybyers mentioned this pull request Jun 21, 2018
Merged
@paddybyers
Copy link
Member Author

Closing (superseded by #447)

@paddybyers paddybyers closed this Jun 22, 2018
@paddybyers paddybyers deleted the fix-rtn15h branch November 16, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@mattheworiordan mattheworiordan mattheworiordan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paddybyers @SimonWoolf @mattheworiordan @tcard @mezis @funkyboy