Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3926] Add tech icon pack, currentColor to GUI icon interiors #574

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

jamiehenson
Copy link
Member

@jamiehenson jamiehenson commented Dec 9, 2024

Jira Ticket Link / Motivation + summary

Supporting work for the left/right nav redo on docs - we need more icons to support the language dropdown, so this adds the ones we need, as well as the rest of the missing tech icon resources from Figma.

Also, this modifies a number of GUI icons to use currentColor for their interior fill, which will allow us to change the color of these icons with CSS.

We're replacing GUI icons with Hero icons at some point, but not right now.

How do you manually test this?

Book (we have lots and lots of tech icons now)

Reviewer Tasks (optional)

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

Summary by CodeRabbit

  • Chores
    • Updated the project version from 15.1.4 to 15.1.5 in the package configuration.

Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Walkthrough

The pull request includes an update to the package.json file for the @ably/ui project, specifically changing the version number from 15.1.4 to 15.1.5. This is a straightforward version bump with no changes made to dependencies, scripts, or other configurations within the file. All other fields in the package.json remain unchanged.

Changes

File Change Summary
package.json Updated version from 15.1.4 to 15.1.5

Assessment against linked issues

Objective Addressed Explanation
Update docs left side bar (WEB-3926) No changes related to documentation were made.

Possibly related PRs

Suggested reviewers

  • aralovelace
  • kennethkalmer

🐇 Hop along the code, a version we shall see,
From fifteen point one, to five, oh so free!
A bump in the night, with no other change,
Just a simple update, nothing feels strange.
In the land of the code, we dance and we play,
With each little version, we hop on our way! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 285b81e and 69c4aa8.

⛔ Files ignored due to path filters (189)
  • src/core/Icon/__snapshots__/Icon.stories.tsx.snap is excluded by !**/*.snap
  • src/core/icons/icon-gui-chevron-down.svg is excluded by !**/*.svg
  • src/core/icons/icon-gui-chevron-up.svg is excluded by !**/*.svg
  • src/core/icons/icon-gui-partial.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ably-api-streamer.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ably-firehose.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ably-native.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ably.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-activemq.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-activitypub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aerospike.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-akka.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-amazon-ec2.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-amazon-event-bridge.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-amqp091.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-amqp10.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-android-full.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-android-head.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-angular.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-anycable.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apache-cassandra.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apache-cordova.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apache-kafka.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apache-spark.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apachepulsar.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apachestorm.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-apns.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-assemblyai.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-atmosphere.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws-app-sync.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws-aurora.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws-gateway-websockets.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws-sns.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws-sqs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-aws.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-awsiot.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-awskinesis.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-awslambda.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-api.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-archive-api.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-bus.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-cosmos.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-event-hub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-functions.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-search.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-static-web-app.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-static-web-apps.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-storage.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azure-web-pubsub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azurefunctions.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azureservicebus.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-azuresignalR.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-bayeux.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-c++.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-centrifugo.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-client-side-frameworks.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-clojure.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-cloudflare-durable-objects.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-cloudflareworkers.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-cocoa.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-confluent.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-cord.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-csharp.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-curl.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-customwebhooks.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-datadog.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-design-patterns.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-devplatforms.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-diffusion-data.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-django.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-engineio.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-event-driven-servers.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-fanout-io.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-fast-api.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-fauna.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-featherjs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-firebase-cloud-messaging.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-firebase.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-flutter.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-gcloudbigquery.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-gclouddataflow.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-gcloudfunctions.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-gcloudpubsub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-go.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-grpc.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-hivemq.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-http2.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-http3.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-httprest.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-idempotency.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ifttt.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-integrations.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ios-generic.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ios.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ipados.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ipfs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ironmq.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-java.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-javascript.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-jms.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-json-web-tokens.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-kaazing.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-kotlin.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ksql-db.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-kubernetes.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-laravel-broadcast.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-laravel-echo.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-lightstreamer.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-liveblocks.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-longpolling.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-macos.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-matrix.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-meteor.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-mongo-db.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-mono.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-mqtt.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-mysql.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-native-script.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-net.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-netlify.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-nextjs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-nkn.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-nodejs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-objectivec.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-parse-server.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-php.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-planetscale.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-postgres.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-prisma.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-programminglanguages.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-protcol-adaptors.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-protocols.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-pub-sub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-pubnub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-push-technology.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-pusher.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-python.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-quic.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-rabbitMQ.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-railsactioncable.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-react-app.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-react.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-reactnative.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-redis.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-redpanda.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-replicache.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-rethinkdb.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-rocketmq.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-ruby.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-scala.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-scaledrone.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-serversentevents.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-serversideframeworks.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-signalR.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-snowflake.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-socketio.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-sockjs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-solace.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-spring.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-stomp.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-streamdata-io.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-streamr.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-swift.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-symfony-mercure.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-symfony.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-tcp-ip.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-tenefit.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-terraform.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-tvos.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-twilio.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-typescript.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-udp-protocol.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-unity.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-vercel.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-vscode.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-vuejs.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-wamp.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-watchos.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-web-push.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-web.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-webhooks.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-webrtc.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-websockets.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-websub.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-xamarin.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-xhr-streaming.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-xmpp.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-zapier.svg is excluded by !**/*.svg
  • src/core/icons/icon-tech-zeromq.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jamiehenson jamiehenson added review and removed review labels Dec 9, 2024
@jamiehenson jamiehenson requested review from kennethkalmer and a team December 9, 2024 11:57
Copy link
Member

@kennethkalmer kennethkalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants