Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-4078] Refresh app, account, & org gui icons #583

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

kennethkalmer
Copy link
Member

@kennethkalmer kennethkalmer commented Dec 20, 2024

Jira Ticket Link / Motivation

The icons added in #570 had fixed stroke/fill colour values. This replaces them with currentColor. I've also re-exported them from Figma, they are all now slightly higher definition and uniform size (not that that really matters with vector graphics)

How do you manually test this?

Open ye old Storybook and review

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

Summary by CodeRabbit

  • Chores
    • Updated the package version from 15.1.9 to 15.1.10.

Also exported fresh copies from Figma that have a slightly higher
definition
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

This pull request involves a minor version update for the @ably/ui package, incrementing the version number from 15.1.9 to 15.1.10. The change is limited to updating the version field in the package.json file, with no other modifications to dependencies, scripts, or package metadata.

Changes

File Change Summary
package.json Version updated from 15.1.9 to 15.1.10

Possibly related PRs

Suggested labels

review

Suggested reviewers

  • aralovelace
  • jamiehenson

Poem

🐰 A version bump, oh so slight,
From 15.1.9 to 10's bright light!
A tiny change, a number's dance,
In package.json, a version's chance.
Hop along, code's gentle might! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec3d114 and b5a191f.

⛔ Files ignored due to path filters (3)
  • src/core/icons/icon-gui-account.svg is excluded by !**/*.svg
  • src/core/icons/icon-gui-app.svg is excluded by !**/*.svg
  • src/core/icons/icon-gui-organization.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kennethkalmer kennethkalmer force-pushed the WEB-4078-refresh-app-account-org-icons branch from e5a41a0 to b5a191f Compare December 20, 2024 11:23
@kennethkalmer kennethkalmer changed the title [WEB-4078] Refresh app account org icons [WEB-4078] Refresh app, account, & org gui icons Dec 20, 2024
@kennethkalmer kennethkalmer marked this pull request as ready for review December 20, 2024 11:24
@kennethkalmer kennethkalmer self-assigned this Dec 20, 2024
Copy link
Member

@jamiehenson jamiehenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennethkalmer kennethkalmer merged commit 3117564 into main Dec 20, 2024
5 checks passed
@kennethkalmer kennethkalmer deleted the WEB-4078-refresh-app-account-org-icons branch December 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants