Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unified test suite #1813

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Unified test suite #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b3d497
[UTS] Remove files that won’t be in the unified test suite
lawrence-forooghian Jun 20, 2024
e94a8ae
[UTS] Don’t test on multiple transports
lawrence-forooghian Jun 20, 2024
e462871
[UTS] Disable use of bestTransport / availableTransport private APIs
lawrence-forooghian Jun 20, 2024
1fb77af
[UTS] Don’t use private APIs in closeAndFinish
lawrence-forooghian Jun 27, 2024
2d91b41
[UTS] Add some exclusions to private API reporting
lawrence-forooghian Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions scripts/processPrivateApiData/exclusions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,25 @@ type ExclusionRule = {
helper?: string;
};

/**
* This exclusions mechanism is not currently being used on `main`, but I will use it on a separate unified test suite branch in order to exclude some private API usage that can currently be disregarded in the context of the unified test suite.
*/
export function applyingExclusions(usageDtos: PrivateApiUsageDto[]) {
const exclusionRules: ExclusionRule[] = [];
const exclusionRules: ExclusionRule[] = [
// This is all helper stuff that we could pull into the test suite, and which for now we could just continue using the version privately exposed by ably-js, even in the UTS.
{ privateAPIIdentifier: 'call.BufferUtils.areBuffersEqual' },
{ privateAPIIdentifier: 'call.BufferUtils.base64Decode' },
{ privateAPIIdentifier: 'call.BufferUtils.base64Encode' },
{ privateAPIIdentifier: 'call.BufferUtils.hexEncode' },
{ privateAPIIdentifier: 'call.BufferUtils.isBuffer' },
{ privateAPIIdentifier: 'call.BufferUtils.toArrayBuffer' },
{ privateAPIIdentifier: 'call.BufferUtils.utf8Encode' },
{ privateAPIIdentifier: 'call.Utils.copy' },
{ privateAPIIdentifier: 'call.Utils.inspectError' },
{ privateAPIIdentifier: 'call.Utils.keysArray' },
{ privateAPIIdentifier: 'call.Utils.mixin' },
{ privateAPIIdentifier: 'call.Utils.toQueryString' },
{ privateAPIIdentifier: 'call.msgpack.decode' },
{ privateAPIIdentifier: 'call.msgpack.encode' },
{ privateAPIIdentifier: 'call.http.doUri', helper: 'getJWT' },
];

return usageDtos.filter(
(usageDto) =>
Expand Down
Loading
Loading