[WIP] Unified test suite #1813
Draft
[WIP] Unified test suite #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1813/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4834-do-something-with-private-api-data
branch
2 times, most recently
from
16d8f79 to
f770124
Compare
Base automatically changed from
ECO-4834-do-something-with-private-api-data
to
main
July 25, 2024 08:23
lawrence-forooghian
force-pushed
the
unified-test-suite
branch
from
dc4ddc3 to
8d162a0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1813/bundle-report
These are the same files I didn’t add private API usage annotations to in 2dcf4ed. I’m doing this now so that when I make further UTS-related changes I don’t have to think about these files.
This is part of removing some common private API usage for the unified test suite. ably-js is the only client library that offers multiple transports, so testing on multiple transports will probably not be part of the UTS.
This is part of removing some common private API usage for the unified test suite. As mentioned in e94a8ae, client libraries running in unified test suite are expected to only use WebSocket transport.
This is part of removing some common private API usage for the unified test suite. It’s not clear to me why these private APIs were required. Even `nextTick`, which had a comment saying that it is needed by “channelattach_publish_invalid etc” — removing the `nextTick` does not seem to affect those tests (although 4a90e75, which introduced the `nextTick` usage, does describe it as a “race” so perhaps we need to see if failures emerge over time).
These are APIs that for the purposes of the unified test suite we can not consider as private for the time being (so as to not clutter up the private API reporting data).
lawrence-forooghian
force-pushed
the
unified-test-suite
branch
from
8d162a0 to
2d91b41
Compare
lawrence-forooghian
changed the base branch from
main
to
correct-private-api-usage-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting point for the unified test suite (an attempt at reusing the ably-js test suite as a shared test suite for all of our client libraries). It gives @ttypic a starting point for trying to test the SDK adapters. It is unlikely to be merged into
main.