Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update got to v12 #1758

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Update got to v12 #1758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions grunt/esbuild/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ const nodeConfig = {
* doesn't work at all.
*/
external: ['ws', 'got'],
format: 'cjs',
Copy link
Contributor Author

@VeskeR VeskeR May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we bundle node.js as an UMD, we will end up with calling require('got') in the UMD header, which inevitably fails with the [ERR_REQUIRE_ESM] error since got@12 is pure ESM and can't be require'd.
So one option is to stop using UMD for node.js bundle and just bundle it as CJS. Then we will only await import('got') whenever we actually need it

plugins: [],
};

module.exports = {
Expand Down
Loading
Loading