[WIP] Update got to v12
#1758
Draft
[WIP] Update got to v12
#1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeskeR
commented
May 3, 2024
| @@ -52,6 +52,8 @@ const nodeConfig = { | |||
| * doesn't work at all. | |||
| */ | |||
| external: ['ws', 'got'], | |||
| format: 'cjs', | |||
There was a problem hiding this comment.
If we bundle node.js as an UMD, we will end up with calling require('got') in the UMD header, which inevitably fails with the [ERR_REQUIRE_ESM] error since got@12 is pure ESM and can't be require'd.
So one option is to stop using UMD for node.js bundle and just bundle it as CJS. Then we will only await import('got') whenever we actually need it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got@12is the latest version ofgotwe can update to without making very drastic changes to the codebase.Installing
got@13will cause our TS import statements to fail with:and tinkering with
moduleandmoduleResolutionintsconfig.jsonopens up another can of worms which I'm not sure justifies trying to upgrade togot@13