Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test ux improvements #1652

Merged
merged 11 commits into from
Mar 14, 2024
Merged

test: test ux improvements #1652

merged 11 commits into from
Mar 14, 2024

Conversation

owenpearson
Copy link
Member

@owenpearson owenpearson commented Feb 29, 2024

Includes a couple of improvements for the tests in this project:

  • by default, outputs debug logs for failing tests and no logs for passing tests, making the test results much easier to read and allowing us to see full client logs for test flakes in CI (especially helpful if we aren't able to reproduce the flake locally). you can still configure all of the tests to emit logs to stdout by explicitly setting a log level (using ABLY_LOG_LEVEL in nodejs or the log_level query param in browser).
  • use source map for node tests (no more stack traces pointing to 'ably-node:8392')
  • uses the mocha CLI to run node tests, avoiding the grunt-mocha task. this makes it easier to leverage mocha's CLI options and means that the output works with colorterm, see screenshots:

example test stdout with colorterm:
image
example test failure output:
image

@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 11:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 11:35 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 11:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 11:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 11:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 11:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 11:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 11:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 11:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 12:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 12:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 12:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 12:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 12:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 12:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 12:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 13:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 13:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 13:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features February 29, 2024 14:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report February 29, 2024 14:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc February 29, 2024 14:21 Inactive
@VeskeR VeskeR self-requested a review March 7, 2024 16:11
@VeskeR
Copy link
Contributor

VeskeR commented Mar 7, 2024

@VeskeR I've added 61e28de to make the web_server executable a module

Thank you!
And removal of kexec is a nice side effect of this change, that package was not compatible with Windows at all.

test/support/runPlaywrightTests.js Outdated Show resolved Hide resolved
Gruntfile.js Outdated Show resolved Hide resolved
Gruntfile.js Show resolved Hide resolved
test/web_server.js Outdated Show resolved Hide resolved
test/web_server.js Outdated Show resolved Hide resolved
@owenpearson owenpearson requested a review from VeskeR March 7, 2024 16:47
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features March 7, 2024 16:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report March 7, 2024 16:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc March 7, 2024 16:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/features March 7, 2024 16:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/bundle-report March 7, 2024 16:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1652/typedoc March 7, 2024 17:00 Inactive
@owenpearson owenpearson merged commit a32bc6c into integration/v2 Mar 14, 2024
12 checks passed
@owenpearson owenpearson deleted the test-improvements branch March 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants