Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: flush logs after each test #1714

Merged
merged 1 commit into from
Mar 25, 2024
Merged

test: flush logs after each test #1714

merged 1 commit into from
Mar 25, 2024

Conversation

owenpearson
Copy link
Member

must have accidentally lost this hook during a rebase, whoops

@owenpearson
test: flush logs after each test
265ae3a 
must have accidentally lost this hook during a rebase, whoops
@VeskeR
Copy link
Contributor

VeskeR commented Mar 25, 2024

Yep, it got lost in this commit (not sure if it was a rebase, maybe just a refactoring bit), as part of the #1652

@owenpearson owenpearson requested a review from VeskeR March 25, 2024 15:05
@owenpearson owenpearson marked this pull request as ready for review March 25, 2024 15:05
VeskeR
VeskeR approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenpearson owenpearson merged commit df84ac3 into main Mar 25, 2024
12 checks passed
@owenpearson owenpearson deleted the flush-logs-after-test branch March 25, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeskeR VeskeR VeskeR approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @VeskeR