Upgrade Playwright to 1.39.0 #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1485/features
github-actions
bot
temporarily deployed
to
staging/pull/1485/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1485/bundle-report
This requires us to now explicitly install the browsers (see [1]). I’m doing this upgrade not because it’s necessary but because NPM tried to make it for me when resolving a package-lock.json merge conflict in an upcoming commit. Given that the upgrade involves this CI change, thought it best to do it as a separate commit so it doesn’t get lost inside a merge commit. [1] https://playwright.dev/docs/release-notes#breaking-changes-playwright-no-longer-downloads-browsers-automatically
lawrence-forooghian
force-pushed
the
upgrade-playwright-to-latest
branch
from
218699f to
54932b4
Compare
ttypic
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires us to now explicitly install the browsers (see this section of Playwright release notes).
I’m doing this upgrade not because it’s necessary but because NPM tried to make it for me when resolving a
package-lock.jsonmerge conflict in an upcoming commit. Given that the upgrade involves this CI change, thought it best to do it as a separate commit so it doesn’t get lost inside a merge commit.