Skip to content

Commit

Permalink
Upgrade Playwright to 1.39.0
Browse files Browse the repository at this point in the history
This requires us to now explicitly install the browsers (see [1]).

I’m doing this upgrade not because it’s necessary but because NPM tried
to make it for me when resolving a package-lock.json merge conflict in
an upcoming commit. Given that the upgrade involves this CI change,
thought it best to do it as a separate commit so it doesn’t get lost
inside a merge commit.

[1] https://playwright.dev/docs/release-notes#breaking-changes-playwright-no-longer-downloads-browsers-automatically
  • Loading branch information
lawrence-forooghian committed Nov 3, 2023
1 parent b87ac65 commit 218699f
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
with:
node-version: 16.x
- run: npm ci
- name: Install playwright dependencies
run: sudo npx playwright install-deps
- name: Install playwright browsers and dependencies
run: sudo npx playwright install --with-deps
- env:
PLAYWRIGHT_BROWSER: ${{ matrix.browser }}
run: npm run test:playwright
64 changes: 45 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"minimist": "^1.2.5",
"mocha": "^8.1.3",
"null-loader": "^4.0.1",
"playwright": "^1.10.0",
"playwright": "^1.39.0",
"prettier": "^2.5.1",
"react": ">=18.1.0",
"react-dom": ">=18.1.0",
Expand Down

0 comments on commit 218699f

Please sign in to comment.