-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4629] fix: propagate id and key fields for connection object for Android and iOS #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttypic
changed the title
[ECO-4629] fix propagate id and key fields for connection object for Android
[ECO-4629] fix: propagate id and key fields for connection object for Android
Feb 26, 2024
github-actions
bot
temporarily deployed
to
staging/pull/505/features
February 26, 2024 10:21
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/505/dartdoc
February 26, 2024 10:22
Inactive
ttypic
force-pushed
the
ECO-4629/fix-connection-fields
branch
from
February 26, 2024 10:32
6cac7f8
to
37ca254
Compare
github-actions
bot
temporarily deployed
to
staging/pull/505/features
February 26, 2024 10:32
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/505/dartdoc
February 26, 2024 10:32
Inactive
sacOO7
reviewed
Feb 26, 2024
sacOO7
reviewed
Feb 26, 2024
android/src/main/java/io/ably/flutter/plugin/dto/EnrichedConnectionStateChange.java
Show resolved
Hide resolved
Add `key` and `id` to `ConnectionStateChange` event, updated example app
ttypic
force-pushed
the
ECO-4629/fix-connection-fields
branch
from
February 26, 2024 12:25
37ca254
to
4ead8d1
Compare
github-actions
bot
temporarily deployed
to
staging/pull/505/features
February 26, 2024 12:26
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/505/dartdoc
February 26, 2024 12:26
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/505/features
February 26, 2024 14:31
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/505/dartdoc
February 26, 2024 14:31
Inactive
maratal
reviewed
Feb 26, 2024
maratal
force-pushed
the
ECO-4629/fix-connection-fields
branch
from
February 27, 2024 23:56
16edd36
to
cfebecd
Compare
sacOO7
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maratal
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maratal
changed the title
[ECO-4629] fix: propagate id and key fields for connection object for Android
[ECO-4629] fix: propagate id and key fields for connection object for Android and iOS
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #502
Jira issue ECO-4629
Add
key
andid
toConnectionStateChange
event, updated example app