-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix realtime connection fields #503
Conversation
c7f006b
to
3a109df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sachin. It works well. However, I don't really like that we've changed existing fields to async props, even if these fields never worked properly.
I think we should either create new async methods with different names as a workaround in the Connection instead or come up with a solution for making them work as fields (similar to state
).
I'm not sure what is happening in this PR since as I said I'm not familiar with the flutter codebase, but can't |
682d4f1
to
5f40d84
Compare
2e05366
to
032948f
Compare
Marking as resolved, since it's already fixed as a part of #505 |
id
,key
andrecoveryKey
.