Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PublicKey when exposing internals to strongly named assemblies #1082

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/IO.Ably.NETStandard20/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]
[assembly: InternalsVisibleTo("IO.Ably.Push.Android")]
[assembly: InternalsVisibleTo("IO.Ably.Push.iOS")]
[assembly: InternalsVisibleTo("IO.Ably.Push.Android, PublicKey=002400000480000094000000060200000024000052534131000400000100010001394bb0af9eb8e04f43676c91691de20f2137847e153e27bb96cf2dedf43bce3073f699ca136fb7f9eea0d9b9c6748e9c0be5543761945e101062f8770129512c4c397a08c1b459357e7a49a4dfd7e16ac9c84d1ab3fe1177b3e7741ea10eba746433691bbf1ad643bdf25bcf397a384f96e8d138b129bdb663189200d33dcf")]
[assembly: InternalsVisibleTo("IO.Ably.Push.iOS, PublicKey=002400000480000094000000060200000024000052534131000400000100010001394bb0af9eb8e04f43676c91691de20f2137847e153e27bb96cf2dedf43bce3073f699ca136fb7f9eea0d9b9c6748e9c0be5543761945e101062f8770129512c4c397a08c1b459357e7a49a4dfd7e16ac9c84d1ab3fe1177b3e7741ea10eba746433691bbf1ad643bdf25bcf397a384f96e8d138b129bdb663189200d33dcf")]
#if !PACKAGE
[assembly: InternalsVisibleTo("IO.Ably.Tests.DotNetCore20")]
#endif
7 changes: 7 additions & 0 deletions src/IO.Ably.Push.Android/IO.Ably.Push.Android.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<PropertyGroup>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>IO.Ably.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<Reference Include="Java.Interop" />
<Reference Include="Mono.Android" />
Expand Down Expand Up @@ -317,6 +323,7 @@
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<None Include="IO.Ably.snk" />
<None Include="packages.config" />
<None Include="Resources\AboutResources.txt" />
</ItemGroup>
Expand Down
Binary file added src/IO.Ably.Push.Android/IO.Ably.snk
Binary file not shown.
7 changes: 7 additions & 0 deletions src/IO.Ably.Push.iOS/IO.Ably.Push.iOS.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
</PropertyGroup>
<PropertyGroup>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>IO.Ably.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<Reference Include="OpenTK-1.0" />
<Reference Include="System" />
Expand All @@ -54,6 +60,7 @@
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<None Include="IO.Ably.snk" />
<None Include="packages.config" />
<AdditionalFiles Include="..\stylecop.json" />
</ItemGroup>
Expand Down
Binary file added src/IO.Ably.Push.iOS/IO.Ably.snk
Binary file not shown.