Missing PublicKey when exposing internals to strongly named assemblies #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Push assemblies for iOS and Android need to provide their public key, this resolves: "Strong-name signed assemblies must specify a public key in their InternalsVisibleTo declarations"
sacOO7
approved these changes
Jan 6, 2022
marto83
approved these changes
Jan 6, 2022
tomkirbygreen
deleted the
provide-satellite-public-key-when-exposing-internals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Push assemblies for iOS and Android need to provide their public
key, this resolves:
"Strong-name signed assemblies must specify a public key in their
InternalsVisibleTo declarations"
Note: It was necessary to make project local copies of the Strong Name Key file, I tried using relative references (
"../../IO.Ably.snk") but this didn't work. I don't like the associated smell of duplicating the file and have a GitHub Issue under which I hope to address the pre-existing and new duplication.