Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3930] Removed unnecessary re-attach attempt. #1822

Merged
merged 1 commit into from
Nov 25, 2023
Merged

[SDK-3930] Removed unnecessary re-attach attempt. #1822

merged 1 commit into from
Nov 25, 2023

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Nov 5, 2023

Closes #1821

@maratal maratal mentioned this pull request Nov 5, 2023
Merged
lawrence-forooghian
lawrence-forooghian approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got no idea what the original code was trying to do. I'm approving based on the fact that it hasn't caused any test failures.

@maratal maratal merged commit df914e1 into main Nov 25, 2023
6 checks passed
@maratal maratal deleted the fix/1821-extra-re-attach branch November 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra re-attach forgotten to be removed.
2 participants
@maratal @lawrence-forooghian