[SDK-1494] No connection serial #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maratal
force-pushed
the
feature/no-connection-serial
branch
from
8523765 to
c22a2f5
Compare
maratal
force-pushed
the
feature/no-connection-serial
branch
from
c0433e7 to
9b8d443
Compare
maratal
force-pushed
the
feature/no-connection-serial
branch
from
c3577db to
2f8cf26
Compare
maratal
force-pushed
the
feature/no-connection-serial
branch
from
2f8cf26 to
9243472
Compare
maratal
force-pushed
the
feature/no-connection-serial
branch
from
9243472 to
fdbd4ac
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
maratal
force-pushed
the
feature/no-connection-serial
branch
from
c7da04b to
56daacf
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
maratal
force-pushed
the
feature/no-connection-serial
branch
from
56daacf to
afb93ce
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
maratal
force-pushed
the
feature/no-connection-serial
branch
from
afb93ce to
fb01ab8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
maratal
force-pushed
the
feature/no-connection-serial
branch
4 times, most recently
from
e4b847e to
6e62c70
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1714/features
github-actions
bot
temporarily deployed
to
staging/pull/1714/jazzydoc
There was a problem hiding this comment.
Cool, looks good. Only thing left to do, I think, is to do something about this enormous commit history so it's more understandable for people looking at the codebase in the future. Up to you what you want to do here — I’m happy for it to all be squashed into one commit if that's what you feel most comfortable doing. Would be good for the commit message to contain any information that you feel is useful from the current 104 commits, though.
maratal
force-pushed
the
feature/no-connection-serial
branch
from
6e62c70 to
9618f95
Compare
jamienewcomb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No connection serial implementation for ably-cocoa.
Closes #1494
This is a rework of the initial PR #1496 which has become messy.