Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try CI on macOS 13 explicitly. #1760

Closed
wants to merge 6 commits into from
Closed

Try CI on macOS 13 explicitly. #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36d945e
Try run on macos-13 and Xcode 14.3
maratal Jun 22, 2023
dd436f9
Updated Carthage build script to Xcode 14
maratal Jun 22, 2023
71314b5
Updated logs path
maratal Jun 22, 2023
2cc544b
Added Upload xcodebuild logs step for all workflows.
maratal Jun 25, 2023
b01991e
Revert "Updated Carthage build script to Xcode 14"
maratal Jun 25, 2023
713f03a
Try with Xcode 14.2 for tvOS
maratal Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/check-pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ on:

jobs:
check:
runs-on: macos-latest
runs-on: macos-13
steps:
- uses: actions/checkout@v2

- name: Select Specific Xcode Version (13.4.1)
- name: Select Specific Xcode Version (14.3)
run: |
sudo xcode-select -s /Applications/Xcode_13.4.1.app
sudo xcode-select -s /Applications/Xcode_14.3.app
echo "Selected Xcode version:"
xcodebuild -version

Expand All @@ -32,6 +32,14 @@ jobs:
run: make update
- name: Build Ably framework
run: make carthage_package

- name: Upload carthage xcodebuild logs
if: always()
uses: actions/upload-artifact@v2
with:
name: carthage-xcodebuild-logs
path: /var/folders/2p/*/T/carthage-xcodebuild*.log

- name: Print contents of generated ZIP file
run: |
unzip -l Ably.framework.zip
Expand Down
23 changes: 18 additions & 5 deletions ...b/workflows/integration-test-iOS16_2.yaml → ...b/workflows/integration-test-iOS16_4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Integration Test: iOS 16.2"
name: "Integration Test: iOS 16.4"

on:
pull_request:
Expand All @@ -12,7 +12,7 @@ on:

jobs:
check:
runs-on: macos-latest
runs-on: macos-13

env:
LC_CTYPE: en_US.UTF-8
Expand All @@ -22,6 +22,12 @@ jobs:
steps:
- name: Check out SDK repo
uses: actions/checkout@v2

- name: Select Specific Xcode Version (14.3)
run: |
sudo xcode-select -s /Applications/Xcode_14.3.app
echo "Selected Xcode version:"
xcodebuild -version

- name: Log environment information
run: ./Scripts/log-environment-information.sh
Expand Down Expand Up @@ -54,7 +60,14 @@ jobs:
make submodules
bundle install
make update_carthage_dependencies_ios
bundle exec fastlane test_iOS16_2
bundle exec fastlane test_iOS16_4

- name: Upload carthage xcodebuild logs
if: always()
uses: actions/upload-artifact@v2
with:
name: carthage-xcodebuild-logs
path: /var/folders/2p/*/T/carthage-xcodebuild*.log

- name: Check Static Analyzer Output
id: analyzer-output
Expand All @@ -70,15 +83,15 @@ jobs:
if: ${{ failure() && steps.analyzer-output.outcome == 'failure' }}
uses: actions/upload-artifact@v2
with:
name: static-analyzer-reports-test_iOS16_2
name: static-analyzer-reports-test_iOS16_4
path: ./derived_data/**/report-*.html

- name: Run Examples Tests
working-directory: ./Examples/Tests
run: |
pod repo update
pod install
bundle exec fastlane scan -s Tests --output-directory "fastlane/test_output/examples/test_iOS16_2"
bundle exec fastlane scan -s Tests --output-directory "fastlane/test_output/examples/test_iOS16_4"

- name: Build APNS Example Project
working-directory: ./Examples/AblyPush
Expand Down
17 changes: 15 additions & 2 deletions ...hub/workflows/integration-test-macOS.yaml → ...b/workflows/integration-test-macOS13.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Integration Test: macOS Latest"
name: "Integration Test: macOS 13"

on:
pull_request:
Expand All @@ -12,7 +12,7 @@ on:

jobs:
check:
runs-on: macos-latest
runs-on: macos-13

env:
LC_CTYPE: en_US.UTF-8
Expand All @@ -22,6 +22,12 @@ jobs:
steps:
- name: Check out SDK repo
uses: actions/checkout@v2

- name: Select Specific Xcode Version (14.3)
run: |
sudo xcode-select -s /Applications/Xcode_14.3.app
echo "Selected Xcode version:"
xcodebuild -version

- name: Log environment information
run: ./Scripts/log-environment-information.sh
Expand Down Expand Up @@ -56,6 +62,13 @@ jobs:
make update_carthage_dependencies_macos
bundle exec fastlane test_macOS

- name: Upload carthage xcodebuild logs
if: always()
uses: actions/upload-artifact@v2
with:
name: carthage-xcodebuild-logs
path: /var/folders/2p/*/T/carthage-xcodebuild*.log

- name: Check Static Analyzer Output
id: analyzer-output
run: |
Expand Down
23 changes: 18 additions & 5 deletions .../workflows/integration-test-tvOS16_1.yaml → .../workflows/integration-test-tvOS16_4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Integration Test: tvOS 16.1"
name: "Integration Test: tvOS 16.4"

on:
pull_request:
Expand All @@ -12,7 +12,7 @@ on:

jobs:
check:
runs-on: macos-latest
runs-on: macos-13

env:
LC_CTYPE: en_US.UTF-8
Expand All @@ -22,6 +22,12 @@ jobs:
steps:
- name: Check out SDK repo
uses: actions/checkout@v2

- name: Select Specific Xcode Version (14.2)
run: |
sudo xcode-select -s /Applications/Xcode_14.2.app
echo "Selected Xcode version:"
xcodebuild -version

- name: Log environment information
run: ./Scripts/log-environment-information.sh
Expand Down Expand Up @@ -54,7 +60,14 @@ jobs:
make submodules
bundle install
make update_carthage_dependencies_tvos
bundle exec fastlane test_tvOS16_1
bundle exec fastlane test_tvOS16_4

- name: Upload carthage xcodebuild logs
if: always()
uses: actions/upload-artifact@v2
with:
name: carthage-xcodebuild-logs
path: /var/folders/2p/*/T/carthage-xcodebuild*.log

- name: Check Static Analyzer Output
id: analyzer-output
Expand All @@ -70,15 +83,15 @@ jobs:
if: ${{ failure() && steps.analyzer-output.outcome == 'failure' }}
uses: actions/upload-artifact@v2
with:
name: static-analyzer-reports-test_tvOS16_1
name: static-analyzer-reports-test_tvOS16_4
path: ./derived_data/**/report-*.html

- name: Run Examples Tests
working-directory: ./Examples/Tests
run: |
pod repo update
pod install
bundle exec fastlane scan -s Tests --output-directory "fastlane/test_output/examples/test_tvOS_16_1"
bundle exec fastlane scan -s Tests --output-directory "fastlane/test_output/examples/test_tvOS_16_4"

- name: Xcodebuild Logs Artifact
if: always()
Expand Down
4 changes: 2 additions & 2 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ end
platform :ios do

LANE_CONFIGS = [
LaneConfig.new(:test_iOS16_2, "Ably-iOS", ["iPhone 14 (16.2)"]),
LaneConfig.new(:test_tvOS16_1, "Ably-tvOS", ["Apple TV 4K (2nd generation) (16.1)"]),
LaneConfig.new(:test_iOS16_4, "Ably-iOS", ["iPhone 14 (16.4)"]),
LaneConfig.new(:test_tvOS16_4, "Ably-tvOS", ["Apple TV 4K (3rd generation) (16.4)"]),
LaneConfig.new(:test_macOS, "Ably-macOS")
]

Expand Down