Try CI on macOS 13 explicitly.

[maratal]

Not for merging

[maratal]

This run for iOS was made with the Nimble v11 (the commit unfortunately was lost because of force push), and failed tests are the same as in tvOS run with the Nimble v9. So I guess it has something to do with the Xcode 14.3 and not Nimble (under Xcode 14.2 on macOS 12.6 these tests succeed).

This run shows that it doesn't depend on Xcode version (fails with similar set of tests on Xcode 14.2), so it's macOS 13 thing. @lawrence-forooghian Couldn't you please check these set of tests locally?

Failing tests:
	RealtimeClientChannelTests.test__011__Channel__EventEmitter__channel_states_and_events__ChannelStateChange_will_contain_a_resumed_boolean_attribute_with_value__true__if_the_bit_flag_RESUMED_was_included()
	RealtimeClientChannelTests.test__016__Channel__connection_state__if_the_connection_state_enters_the_DISCONNECTED_state__it_will_have_no_effect_on_the_channel_states()
	RealtimeClientChannelTests.test__081__Channel__publish__Connection_state_conditions__the_message__should_NOT_be_queued_instead_it_should_be_published_if_the_channel_is__ATTACHED()
	RealtimeClientChannelTests.test__081__Channel__publish__Connection_state_conditions__the_message__should_NOT_be_queued_instead_it_should_be_published_if_the_channel_is__ATTACHED()
	RealtimeClientChannelTests.test__081__Channel__publish__Connection_state_conditions__the_message__should_NOT_be_queued_instead_it_should_be_published_if_the_channel_is__ATTACHED()
	RealtimeClientChannelTests.test__082__Channel__publish__Connection_state_conditions__will_result_in_an_error_if_the__connection_is_SUSPENDED()
	RealtimeClientConnectionTests.test__033__Connection__ACK_and_NACK__ProtocolMessage__should_continue_incrementing_msgSerial_serially_if_the_connection_resumes_successfully()
	RealtimeClientConnectionTests.test__033__Connection__ACK_and_NACK__ProtocolMessage__should_continue_incrementing_msgSerial_serially_if_the_connection_resumes_successfully()
	RealtimeClientConnectionTests.test__054__Connection__connection_request_fails__on_DISCONNECTED_after_CONNECTED__should_not_emit_error_with_a_renewable_token()
	RealtimeClientConnectionTests.test__056__Connection__connection_request_fails__should_transition_to_disconnected_when_the_token_renewal_fails()
	RealtimeClientConnectionTests.test__056__Connection__connection_request_fails__should_transition_to_disconnected_when_the_token_renewal_fails()
	RealtimeClientConnectionTests.test__078__Connection__connection_failures_once_CONNECTED__DISCONNECTED_message_contains_a_token_error__and_the_library_does_not_have_a_means_to_renew_the_token__the_connection_will_transition_to_the_FAILED_state()
	RealtimeClientConnectionTests.test__108__Connection__Operating_System_events_for_network_internet_connectivity_changes__re_authenticate_and_resume_the_connection_when_the_client_is_forcibly_disconnected_following_a_DISCONNECTED_message_containing_an_error_code_greater_than_or_equal_to_40140_and_less_than_40150()
	RealtimeClientConnectionTests.test__108__Connection__Operating_System_events_for_network_internet_connectivity_changes__re_authenticate_and_resume_the_connection_when_the_client_is_forcibly_disconnected_following_a_DISCONNECTED_message_containing_an_error_code_greater_than_or_equal_to_40140_and_less_than_40150()
	RealtimeClientConnectionTests.test__108__Connection__Operating_System_events_for_network_internet_connectivity_changes__re_authenticate_and_resume_the_connection_when_the_client_is_forcibly_disconnected_following_a_DISCONNECTED_message_containing_an_error_code_greater_than_or_equal_to_40140_and_less_than_40150()

[lawrence-forooghian]

I'll try running on Xcode 14.2 on macOS 13. But I'm a bit confused — if you've seen the same test failures on tvOS 16.4 (which is what I understand from #1760 (comment)) then what makes you think it's a "macOS 13 thing"?

[lawrence-forooghian]

I ran the macOS tests on commit 01b0eb7, on my machine with macOS 13.4.1, with Xcode 14.2, and did not get any test failures.

[maratal]

I'll try running on Xcode 14.2 on macOS 13. But I'm a bit confused — if you've seen the same test failures on tvOS 16.4 (which is what I understand from #1760 (comment)) then what makes you think it's a "macOS 13 thing"?

It's because that run under tvOS has an invalid setup - tvOS 16.4 on Xcode 14.2. Shouldn't be the case. So yeah, it's a Xcode 14.3 thing (including macOS 13 itself run)

[maratal]

Another set of experiments finally showed that this depends only on whether it's on CI macOS 13. The same tests on macOS, iOS and tvOS failed under macOS 13 and Xcode 14.2 (they are fine on Xcode 14.2 under macOS 12). Here are the same failures under Xcode 14.3. Also here the same failures on macOS 13 and Xcode 14.3 for tvOS, but with old Nimble (tvOS compiles in Xcode 14.3 without need to update Nimble for some reason).

All those tests succeed locally on macOS 13 and Xcode 14.3 for all platforms. @lawrence-forooghian

[maratal]

This work is done in #1801