Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get back resumed property in ARTChannelStateChangeParams along with the removed test (for RTL2f) #1920

Closed
maratal opened this issue May 19, 2024 · 1 comment · Fixed by #1921
Closed

Get back resumed property in ARTChannelStateChangeParams along with the removed test (for RTL2f) #1920

maratal opened this issue May 19, 2024 · 1 comment · Fixed by #1921
Assignees
@maratal

Comments

@maratal
Copy link
Collaborator

maratal commented May 19, 2024 •
edited
Loading

It was introduced as part of no-connection-serial PR. But was erroneously removed during review process.

It was used in the test which was removed since the claimed spec (RTL2f) is vague on this ("A test should exist to ensure that resumed is always false when a channel first becomes ATTACHED, it is true when the channel is ATTACHED following a successful connection recovery, and is false when the channel is ATTACHED following a failed connection recovery"), and the test wasn't testing connection recovery mentioned. I've created an issue in the specs repo for this.

┆Issue is synchronized with this Jira Task by Unito
@maratal maratal self-assigned this May 19, 2024
@maratal maratal mentioned this issue May 19, 2024
Merged
@maratal
Copy link
Collaborator Author

maratal commented May 19, 2024

Related issue #1812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Got back resumed property in ARTChannelStateChangeParams along with the test ably/ably-cocoa
1 participant
@maratal