Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable disconnect failed resume faults #947

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Reenable disconnect failed resume faults #947

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d924d22
Increase ably-core version to 1.2.23
ikbalkaya Jan 26, 2023
35f8abd
Enable test for DisconnnectWithFailedResume faults
ikbalkaya Jan 26, 2023
1bfd1f8
Merge branch 'main' into reenable_disconnect_failed_resume_faults
ikbalkaya Jan 26, 2023
d1badac
Remove skipTest completely from DisconnectWithFailedResume fault
ikbalkaya Jan 26, 2023
6bbe281
Reenable EnterUnresponsive
ikbalkaya Jan 26, 2023
e6fc445
Remove unnecesary blank line
ikbalkaya Jan 26, 2023
048a558
Merge branch 'main' into reenable_disconnect_failed_resume_faults
AndyTWF Jan 26, 2023
a9631b6
Merge branch 'main' into reenable_disconnect_failed_resume_faults
AndyTWF Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions android-test-common/src/main/java/com/ably/tracking/test/android/common/Faults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,11 +499,6 @@ class DisconnectWithFailedResume(apiKey: String) : ApplicationLayerFault(apiKey)
}
}

/*
Currently failing due to ably-java#474 presence bug
*/
override val skipTest = true

/**
* State of the fault, used to control whether we're intercepting
* the connection or looking to inject a WebSocket CLOSE at an appropriate time
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
// The version of Ably's client library for Java that we're using.
// Source code: https://github.com/ably/ably-java
// Maven coordinates: groupId 'io.ably', artifactId ':'ably-android'.
ext.ably_core_version = '1.2.22'
ext.ably_core_version = '1.2.23'

repositories {
google()
Expand Down