Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable disconnect failed resume faults #947

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Reenable disconnect failed resume faults #947

merged 8 commits into from
Jan 26, 2023

Conversation

ikbalkaya
Copy link
Contributor

@ikbalkaya ikbalkaya commented Jan 26, 2023 •
edited
Loading

This PR does three things

@ikbalkaya ikbalkaya marked this pull request as ready for review January 26, 2023 11:15
@jaley
Copy link
Contributor

jaley commented Jan 26, 2023

From my testing @ikbalkaya, it should also be safe to reenable EnterUnresponsive?

@github-actions github-actions bot temporarily deployed to staging/pull/947/dokka January 26, 2023 11:20 Inactive
@ikbalkaya
Copy link
Contributor Author

ikbalkaya commented Jan 26, 2023 •
edited
Loading

From my testing @ikbalkaya, it should also be safe to reenable EnterUnresponsive?

@AndyTWF (I mean @jaley 😄 )In my local, only one passes unfortunately. The one with faultBeforeAddingTrackable seems to fail Can you confirm whether both pass on your local 🤔

@ikbalkaya ikbalkaya requested a review from AndyTWF January 26, 2023 12:08
@github-actions github-actions bot temporarily deployed to staging/pull/947/dokka January 26, 2023 12:12 Inactive
@jaley
Copy link
Contributor

jaley commented Jan 26, 2023

OK, no worries. Let's leave it disabled if you're seeing problems and just prioritise getting the ably-java bump landed

@ikbalkaya
Copy link
Contributor Author

ikbalkaya commented Jan 26, 2023 •
edited
Loading

@jaley I realized I had this test run without changes also from main - Now I can confirm that both test pass and I reenabled the EnterUnresponsive fault as well now. I will wait for CI checks pass and merge the changes

@github-actions github-actions bot temporarily deployed to staging/pull/947/dokka January 26, 2023 12:27 Inactive
@ikbalkaya ikbalkaya self-assigned this Jan 26, 2023
jaley
jaley approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@jaley jaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions github-actions bot temporarily deployed to staging/pull/947/dokka January 26, 2023 13:10 Inactive
@AndyTWF AndyTWF merged commit dd5a16c into main Jan 26, 2023
@AndyTWF AndyTWF deleted the reenable_disconnect_failed_resume_faults branch January 26, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyTWF AndyTWF AndyTWF approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@jaley jaley jaley approved these changes

Assignees

@ikbalkaya ikbalkaya

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a trackable stalls forever if presence.enter() is interrupted by a disconnection
4 participants
@ikbalkaya @jaley @AndyTWF @QuintinWillison