Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22_1] improve code of resources to use them inside namespace #321

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

jingkaimori
Copy link
Contributor

split from #320

How to test

Build mogan with this pr and necessary modifications. CI is unreliable here.

@jingkaimori jingkaimori marked this pull request as ready for review April 15, 2024 04:59
@da-liii da-liii changed the title improve code of resources to use them inside namespace. [22_1] improve code of resources to use them inside namespace Apr 15, 2024
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit f782710 into main Apr 15, 2024
12 checks passed
@da-liii da-liii deleted the jingkaimori/resource-improve branch April 15, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants