Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22_2] add api to load shared library #320

Merged
merged 15 commits into from
Apr 15, 2024
Merged

[22_2] add api to load shared library #320

merged 15 commits into from
Apr 15, 2024

Conversation

jingkaimori
Copy link
Contributor

@jingkaimori jingkaimori commented Apr 9, 2024 •
edited
Loading

TODO: add proper configuration on wasm

@jingkaimori jingkaimori requested a review from da-liii April 9, 2024 13:36
@jingkaimori jingkaimori changed the title [no ci] add api to load shared library add api to load shared library Apr 13, 2024
@jingkaimori
Copy link
Contributor Author

jingkaimori commented Apr 13, 2024 •
edited
Loading

Because RESOURCE macro cannot be used inside namespace when building with wasm or MacOS, thus disable shared_lib class on wasm.

@jingkaimori jingkaimori marked this pull request as ready for review April 14, 2024 06:21
@da-liii
Copy link
Contributor

da-liii commented Apr 15, 2024

这个pr需要拆成RESOURCE的更改和剩下的更改两个pr。

其中RESOURCE的更改是影响既有代码的，剩下的更改是新增代码，并不影响既有实现。

@jingkaimori jingkaimori mentioned this pull request Apr 15, 2024
Merged
@jingkaimori jingkaimori force-pushed the jingkaimori/shared-lib-loader branch from ca6f500 to 986dbba Compare April 15, 2024 06:09
da-liii
da-liii approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the test name and the function name

@da-liii da-liii changed the title add api to load shared library [22_2] add api to load shared library Apr 15, 2024
@jingkaimori jingkaimori merged commit 122d03f into main Apr 15, 2024
13 checks passed
@jingkaimori jingkaimori deleted the jingkaimori/shared-lib-loader branch April 15, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da-liii da-liii da-liii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jingkaimori @da-liii