Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Coroutine based webserver #1699

Merged
merged 54 commits into from
Oct 24, 2024

Fix naming in comment

a7a40d4
Select commit
Loading
Failed to load commit list.
Merged

refactor: Coroutine based webserver #1699

Fix naming in comment
a7a40d4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 0s

71.67% (target 50.00%)

View this Pull Request on Codecov

71.67% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 79.74684% with 112 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (cf081e7) to head (a7a40d4).

Files with missing lines Patch % Lines
src/web/ng/Server.cpp 72.32% 31 Missing and 13 partials ⚠️
src/web/ng/impl/HttpConnection.hpp 56.25% 13 Missing and 15 partials ⚠️
src/web/ng/impl/WsConnection.hpp 72.72% 11 Missing and 1 partial ⚠️
src/web/ng/impl/ConnectionHandler.cpp 89.81% 4 Missing and 7 partials ⚠️
src/web/ng/impl/WsConnection.cpp 37.50% 9 Missing and 1 partial ⚠️
src/web/ng/Response.cpp 91.66% 2 Missing and 1 partial ⚠️
src/web/ng/Request.cpp 95.45% 1 Missing and 1 partial ⚠️
src/util/WithTimeout.hpp 93.33% 0 Missing and 1 partial ⚠️
src/web/Server.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1699      +/-   ##
===========================================
+ Coverage    71.30%   71.67%   +0.37%     
===========================================
  Files          266      276      +10     
  Lines        11143    11655     +512     
  Branches      5710     5929     +219     
===========================================
+ Hits          7945     8354     +409     
- Misses        1669     1730      +61     
- Partials      1529     1571      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov