-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Coroutine based webserver #1699
Conversation
a611c3c
to
633707a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1699 +/- ##
===========================================
+ Coverage 71.30% 71.67% +0.37%
===========================================
Files 266 276 +10
Lines 11143 11655 +512
Branches 5710 5929 +219
===========================================
+ Hits 7945 8354 +409
- Misses 1669 1730 +61
- Partials 1529 1571 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great. It's a huge improvement over the current webserver implementation.
I left a few questions and suggestions. Also, feel free to sprinkle [[nodiscard]]
where it makes sense and maybe noexcept
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Nice ! I just leave some questions.
Code of new coroutine-based web server. The new server is not connected to Clio and not ready to use yet. For #919.
Code of new coroutine-based web server. The new server is not connected to Clio and not ready to use yet.
For #919.