Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1648: Added symbol kind support #146

Merged
merged 4 commits into from
Sep 23, 2024
Merged

FEDX-1648: Added symbol kind support #146

merged 4 commits into from
Sep 23, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Sep 21, 2024

Currently, indexed symbols are just the symbol as declared by the scip spec

This implies there's no way to tell the difference between a class Foo symbol, a mixin Foo symbol, and a extension Foo symbol

This PR populates the kind field on the scip symbol to resolve this, and enable deeper information about each indexed symbol provided by scip-dart

QA

  • Kind is not currently included within snapshot results, lets index the snapshot directory and manually verify kind using scip print
  • Once Test Command sourcegraph/scip#236 is merged, I'll consider adding kind annotation selections so we can write targeted unit tests for this concept

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review September 23, 2024 14:32
@bender-wk bender-wk changed the title Added symbol kind support FEDX-1648: Added symbol kind support Sep 23, 2024
alanknight-wk
alanknight-wk previously approved these changes Sep 23, 2024
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

Generated symbols contain the correct "kind"

Screenshot 2024-09-23 at 11 48 50 AM

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit b24c212 into master Sep 23, 2024
13 checks passed
@rmconsole7-wk rmconsole7-wk deleted the symbol_kind branch September 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants