Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Symbol Kinds for Dart #277

Merged

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Sep 21, 2024

Adds support for 2 SymbolKind types that will be utilized by scip-dart

  • Extension is for annotating dart's extension types, specifically the extension declaration, used for resolving api conflicts

    extension Foo on String {
    //        ^^^ Kind.Extension
      void foo() => print('foo');
    }

    Open to suggestions on a different kind to use for this use case, or even a better name if Extension is to generalized

  • Mixin is for annotating dart mixins

    mixin Foo {
    //    ^^^ Kind.Mixin
        int someField;
    }

Test plan

@matthewnitschke-wk matthewnitschke-wk changed the title Added Extension kind for Dart Added Symbol Kinds for Dart Sep 21, 2024
Copy link
Contributor

@varungandhi-src varungandhi-src left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to add language-specific cases to Kind. 👍🏽

@varungandhi-src varungandhi-src merged commit 5e6b8fa into sourcegraph:main Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants