Switch structures to use PagedEntityContainer<STRUCTURE> as backing storage
#3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManManson
force-pushed
the
structs_optimized_storage
branch
from
ecdd783 to
ce622e1
Compare
|
Xcode 13.4 (ARM64) build has been cancelled for some reason: https://github.com/Warzone2100/warzone2100/actions/runs/8400925845/job/23008739835?pr=3701 |
past-due
force-pushed
the
structs_optimized_storage
branch
from
ce622e1 to
97cfa40
Compare
|
Forced-pushed on top of latest master (including the changes from #3689), and added |
|
Seems that you've actually reverted the branch to some old state in the process ... |
Signed-off-by: Pavel Solodovnikov <[email protected]>
…g storage 1. Split the structure storage into pages containing 256 structs 2. Disable slot reuse to guard against memory-related issues when some object pointers won't get updated properly, e.g. when transitioning between the base and offworld missions. Signed-off-by: Pavel Solodovnikov <[email protected]>
past-due
force-pushed
the
structs_optimized_storage
branch
from
97cfa40 to
326aaec
Compare
|
Should be fixed - sorry about that! |
|
Everything seems to be OK now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch structures to use
PagedEntityContaineras backing storage.No performance changes expected, except for slightly better memory utilization patterns, e.g. less memory fragmentation.
Signed-off-by: Pavel Solodovnikov [email protected]