Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow distinct source and target projects #294

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

adamribaudo-velir
Copy link
Collaborator

@adamribaudo-velir adamribaudo-velir commented Dec 29, 2023

Description & motivation

This update allows users to set distinct source and target projects. This helps in scenarios where the dbt user is not able to write to the source project. The target project is pulled from the current profile (target.project).

!!Certain variables have been renamed which introduce breaking changes!!

dataset and project no longer exist as the target.dataset and target.project will be used.
New variable: source_project is now required to indicate the source of the GA4 data
New variable: combined_dataset is required when sourcing from multiple properties. This specifies where to copy the cloned data. The target.project will be used to clone data.
property_ids variable is an array and is used to indicate which property IDs to source from. Can be used for single or multi-property instances (ex: [1111111] for 1 property or [1111111,2222222] for 2, etc)

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

@adamribaudo-velir
Copy link
Collaborator Author

@hugocaillol

@hugocaillol
Copy link

hugocaillol commented Jan 2, 2024

@adamribaudo-velir
Admirable reactivity <3

Is it supposed to merged soon ?

I finally managed to override package macros (as suggested to do for default_channel_grouping in the readme) which could have solved the issue for me (I think), but even if I could have used it to combine data in my dbt project instead of the source project, this work will probably useful for other people

@adamribaudo-velir adamribaudo-velir merged commit 6c6d756 into main Jan 4, 2024
1 check passed
@adamribaudo-velir adamribaudo-velir deleted the allow-distinct-source-target-project branch January 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants