-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing multi-project architecture ( issue #231 ) #243
Conversation
Explaination: SQL comments got outputed on same line as creation table commands.
@adamribaudo-velir : I somehow messed up while fixing the merge conflict of PR235. |
@jice-lavocat sorry, I was under the impression that your code would still work correctly if users left the existing variables in place in the format of:
When I use that configuration, I get a compilation error as follows:
Presumably due to this line which would be searching for a dictionary key of 'project' inside the first element of the array which is an integer:
Could you find a way to handle both types of configuration? single project and multi-project? |
Hello ! I started using the Velir package recently and had a bit of an issue with not being able to specify two distinct projects for reading data (the So I looked a bit around and found this pr with some changes I would love to have and was wondering if it had a chance to be implemented in the near future or if I should better accept to make changes locally and make my own custom version of the velir package |
I agree we should take another look at this. There will likely be some breaking changes to update the variable names to reflect the true intention (ex: |
Hello Adam, thank for the answer, I'll keep for updates then |
I went ahead and made this updates :) @hugocaillol Created a new PR so I could start from scratch. See the notes in the PR for the variable name changes and let me know how it works. |
I believe the intention of this PR is contained in #294 which has been merged. Please let me know if you feel otherwise, @jice-lavocat . Closing PR. |
Description & motivation
Updating the
dbt_projects.yml
format to specify the GCPproject
and GA4property_id
.Use case: when sources are spread on different distinct GCP
Projects
.Related to #231
Checklist
dbt test
andpython -m pytest .
to validate existing tests