feat: automatically generated instance_id #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
commented
Jul 8, 2024
| scheduled_executor.thread.join | ||
|
|
||
| Unleash.configuration.instance_id = original_instance_id | ||
| Unleash.configuration.app_name = original_app_name |
There was a problem hiding this comment.
I don't think the property here really mattered for these tests (this should work with any property) so I picked app_name instead.
Pull Request Test Coverage Report for Build 9841463298Details
💛 - Coveralls |
sighphyre
reviewed
Jul 8, 2024
sighphyre
approved these changes
Jul 9, 2024
This was referenced Jul 9, 2024
nunogois
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2392/make-instance-id-autogenned-ruby
This makes
instance_idan automatically generated read-only property, instead of being set by the user.Similar to Unleash/unleash-client-dotnet#226