Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: automatically generated instance_id (#179)" #185

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

nunogois
Copy link
Member

@nunogois nunogois requested a review from sighphyre July 15, 2024 11:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9938641755

Details

  • 15 of 25 (60.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/unleash/scheduled_executor_spec.rb 5 15 33.33%
Totals Coverage Status
Change from base Build 9875914991: 0.005%
Covered Lines: 2554
Relevant Lines: 2629

💛 - Coveralls

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunogois nunogois merged commit 7d13a8d into main Jul 15, 2024
40 checks passed
@nunogois nunogois deleted the chore-revert-automatically-generated-instanceid branch July 15, 2024 14:04
@Drowze
Copy link

Drowze commented Jul 17, 2024

Just to confirm: we had a couple of our apps updated to v5.0.3 (before this revert) and had Unleash crashing:

/usr/local/bundle/gems/unleash-5.0.3/lib/unleash/configuration.rb:136:in `set_option': undefined method `instance_id=' for an instance of Unleash::Configuration (NoMethodError)
      __send__("#{opt}=", val)
      ^^^^^^^^```

Was this reverted because of the above issue? If yes, maybe it'd best to yank it from rubygems as well (I see it's still there) since that version looks broken.

@sighphyre
Copy link
Member

Just to confirm: we had a couple of our apps updated to v5.0.3 (before this revert) and had Unleash crashing:

/usr/local/bundle/gems/unleash-5.0.3/lib/unleash/configuration.rb:136:in `set_option': undefined method `instance_id=' for an instance of Unleash::Configuration (NoMethodError)
      __send__("#{opt}=", val)
      ^^^^^^^^```

Was this reverted because of the above issue? If yes, maybe it'd best to yank it from rubygems as well (I see it's still there) since that version looks broken.

Apologies for that and thanks for the suggestion, it's been removed from rubygems now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants