-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added service to enable and disable tool contact #940
base: main
Are you sure you want to change the base?
Conversation
Split this pull request into two. This PR now only implements the tool contact functionality and testing of that (Will only work on E-series robots). The get_version service implementation has been moved to PR. |
64d0b35
to
d825856
Compare
Also added service to get robot software version.
This reverts commit f6bf8c6.
I've tested this today and while it seems to be working well, I think the interface should be improved:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
========================================
+ Coverage 3.59% 3.78% +0.18%
========================================
Files 13 395 +382
Lines 947 43518 +42571
Branches 152 6404 +6252
========================================
+ Hits 34 1645 +1611
- Misses 843 41730 +40887
- Partials 70 143 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also added service to get robot software version.