🔨 Fix unused imports and unnecessary using directives #300
+25
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
➖ Get rid of unused `CurrencyLibrary` usages ❌ Get rid of all `using PoolIdLibrary for PoolKey;` directives and `PoolIdLibrary` imports ➕ Add global usage of `PositionConfigIdLibrary` for `PositionConfigId` ➕ Add global usage of `PositionConfigLibrary` for `PositionConfig` ➕ Add global usage of `PathKeyLib` for `PathKey`
|
|
hello! thanks for the contribution, this is quite out of date with current main so I'm going to close. But if you would like to reopen against the most up to date main branch please do, and add me as a reviewer! thanks! |
|
Awesome! Will do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
➖ Get rid of unused
CurrencyLibraryusages❌ Get rid of all
using PoolIdLibrary for PoolKey;directives andPoolIdLibraryimports➕ Add global usage of
PositionConfigIdLibraryforPositionConfigId➕ Add global usage of
PositionConfigLibraryforPositionConfig➕ Add global usage of
PathKeyLibforPathKey