Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Add global usage of PoolIdLibrary for PoolKey struct #819

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

GianfrancoBazzani
Copy link
Contributor

This addition will allow the usage of the method PoolKey.toId() without require to import the PoolIdLibrary and use the using PoolIdLibrary for PoolKey directive.

@GianfrancoBazzani GianfrancoBazzani changed the title ➕ Add global usage of PoolIdLibrary for PoolKey ➕ Add global usage of PoolIdLibrary for PoolKey struct Aug 7, 2024
src/types/PoolKey.sol Show resolved Hide resolved
❌  Get rid of all `using PoolIdLibrary for PoolKey;` directives

❌  Get rid of all unused `PoolIdLibrary` imports

❌  of unnecessary `using CurrencyLibrary for Currency;` directives
@GianfrancoBazzani
Copy link
Contributor Author

hensha256
hensha256 previously approved these changes Aug 29, 2024
@hensha256
Copy link
Contributor

Hi! Sorry you have some merge conflicts form another PR we merged. Please can you fix those?

@GianfrancoBazzani GianfrancoBazzani force-pushed the main branch 2 times, most recently from 8b11daf to 0137bd1 Compare August 30, 2024 14:38
@GianfrancoBazzani
Copy link
Contributor Author

Done!

@snreynolds snreynolds requested a review from hensha256 August 30, 2024 17:30
@snreynolds snreynolds merged commit fbb9caf into Uniswap:main Aug 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants