Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render hidden CSRF token input in reusable non-crispy templates #3157

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Always render hidden CSRF token input in reusable non-crispy templates #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e217946
Always render hidden CSRF token input in reusable non-crispy templates
podliashanyk Nov 5, 2024
713ce0f
Update changelog
podliashanyk Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3157.security.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure that CSRF token info is included when reusing NAV's form templates. This means that flat_form.html and _form_content.html templates will always include a hidden CSRF token input regardless of which form method is set.
4 changes: 1 addition & 3 deletions python/nav/web/templates/custom_crispy_templates/_form_content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{# NB! This template can be used directly (without form template wrapper) for cases where form.helper.form_tag is set to False. #}
{% load forms %}

{% if form.attrs.method|lower == 'post' %}
{% csrf_token %}
{% endif %}
{% csrf_token %}

{% include 'foundation-5/errors.html' %}

Expand Down
Loading