Always render hidden CSRF token input in reusable non-crispy templates #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 31s ⏱️ Results for commit 713ce0f. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
- Coverage 60.45% 60.41% -0.04%
==========================================
Files 605 605
Lines 43745 43734 -11
Branches 48 48
==========================================
- Hits 26448 26424 -24
- Misses 17285 17298 +13
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Nov 5, 2024
|
But I would like to see a changelog file for this change |
|
johannaengland
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more robust version of #3056
This implementation means that CSRF token will be rendered also for GET forms (not so rare form type in NAV) which is a slight redundancy. At the same time it is a worthwhile one since this change means that
_form_content.htmltemplate becomes reusable by forms that were originally non-crispy (with auto-included CSRF token). This is very handy for campus task # 45. Note that there is no (reliable) way to check whether a Django form is a POST form thats why this redundancy is needed.Also see: #3140 (comment)