Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify all of seedDB #3128

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Uncrispify all of seedDB #3128

merged 4 commits into from
Nov 12, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 9, 2024

Closes #2996.

Copy link

github-actions bot commented Oct 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.14s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 9, 2024

Test results

    9 files      9 suites   8m 32s ⏱️
2 137 tests 2 137 ✅ 0 💤 0 ❌
4 013 runs  4 013 ✅ 0 💤 0 ❌

Results for commit f9e31db.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (9245694) to head (f9e31db).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3128      +/-   ##
==========================================
- Coverage   60.39%   60.39%   -0.01%     
==========================================
  Files         605      605              
  Lines       43708    43704       -4     
  Branches       48       48              
==========================================
- Hits        26399    26396       -3     
+ Misses      17297    17296       -1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland self-assigned this Oct 11, 2024
@johannaengland johannaengland force-pushed the refactor/uncrispify-seeddb branch from 6e3ace3 to aac8716 Compare October 11, 2024 11:54
@johannaengland johannaengland changed the base branch from master to refactor/uncrispify-prefix-vlan-form-in-seeddb October 11, 2024 11:55
Base automatically changed from refactor/uncrispify-prefix-vlan-form-in-seeddb to master October 16, 2024 12:24
@johannaengland johannaengland force-pushed the refactor/uncrispify-seeddb branch from aac8716 to e9c9300 Compare October 17, 2024 07:00
@johannaengland johannaengland marked this pull request as ready for review October 17, 2024 07:17
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johannaengland johannaengland force-pushed the refactor/uncrispify-seeddb branch from e9c9300 to f9e31db Compare November 12, 2024 14:31
Copy link

sonarcloud bot commented Nov 12, 2024

@johannaengland johannaengland merged commit 3f0faab into master Nov 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy all edit- and add-forms in /sedddb
2 participants