Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify PrefixVlanForm in seedDB #3119

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 9, 2024

Copy link

github-actions bot commented Oct 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.32s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 9, 2024

Test results

    8 files      8 suites   8m 12s ⏱️
2 046 tests 2 046 ✅  0 💤 0 ❌
3 918 runs  3 908 ✅ 10 💤 0 ❌

Results for commit e78f275.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (1e9d859) to head (e78f275).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3119   +/-   ##
=======================================
  Coverage   60.44%   60.44%           
=======================================
  Files         605      605           
  Lines       43749    43749           
  Branches       48       48           
=======================================
  Hits        26443    26443           
  Misses      17294    17294           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

python/nav/web/templates/seeddb/edit_prefix.html Outdated Show resolved Hide resolved
python/nav/web/seeddb/page/prefix.py Outdated Show resolved Hide resolved
@johannaengland johannaengland requested a review from stveit October 10, 2024 11:42
@johannaengland johannaengland force-pushed the refactor/uncrispify-prefix-vlan-form-in-seeddb branch from 466f5df to e78f275 Compare October 11, 2024 11:44
Copy link

sonarcloud bot commented Oct 11, 2024

@johannaengland johannaengland merged commit e05d09b into master Oct 16, 2024
12 of 14 checks passed
@johannaengland johannaengland deleted the refactor/uncrispify-prefix-vlan-form-in-seeddb branch October 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify PrefixVlanForm in seedDB
4 participants