Fix remaining raft issues #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the Andrew’s Monotone Chain Convex Hull Algorithm.
We already implemented it for the raft top, see #1989 CURA-11395
casperlamboo
force-pushed
the
CURA-11395-fix-convex-hull-raft-polygons
branch
from
72ab846 to
0265e74
Compare
nallath
approved these changes
Jan 15, 2024
instead of the whole polygon CURA-11395
So we get an actual reason for the crash before the program halts CURA-11395
Would rather use modern cpp but compilers :( CURA-11395
for benchmark testing CURA-11395
saumyaj3
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two issues remaining from PR #2006. The issues were the following
Issues with convex hull
Was caused by some unhandled edge cases in our convex hull implementation. Fixed here: c4846cb
Partially printed raft layers
Fixed here: 37295d6
CURA-11395
Type of change
How Has This Been Tested?
Yes
Test Configuration:
Checklist: