Don't include holes in convex hull

CURA-11395
Ultimaker · Jan 11, 2024 · 0265e74 · 0265e74 · rburema · Jan 11, 2024
1 parent 047edff
commit 0265e74
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/utils/polygon.cpp b/src/utils/polygon.cpp
@@ -105,6 +105,15 @@ Polygons Polygons::approxConvexHull(int extra_outset)
 
 void Polygons::makeConvex()
 {
+    // early out if there is nothing to do
+    if (empty())
+    {
+        return;
+    }
+
+    // convex hulls cannot have holes, so remove all paths except the outerpath
+    this->paths.resize(1);
+
     // Andrew’s Monotone Chain Convex Hull Algorithm
     for (PolygonRef poly : *this)
     {