Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spanish translation for lightning infill #16758

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

Pelochus
Copy link
Contributor

Description

Lightning infill was translated as "Iluminación" which means "lighting" (not to be confused with lightning). Lightning actually means "Rayo" or "Rayos" (spanish plural for lightning).

Fix

The translation has been fixed as "Rayos" since it better matches to the infill type, since it has more than one lightning.

You can read this link to verify the translation is correct

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

Note

I have already made this PR previously, but closed it accidentally, sorry for my mistake.

Substituted "iluminación" (lighting) for "rayos" (lightning)
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Sep 19, 2023
@MariMakes MariMakes added the PR: Translations 📚 A PR that introduces or adjusts translation files label Oct 11, 2023
@MariMakes
Copy link
Contributor

Hi @Pelochus,

Sorry, it took us a while to get back to you 😞
This looks like a good improvement, but must have gotten lost in the 5.5 release efforts.
I'll raise it with the team to see if we can include it soon.

@Pelochus
Copy link
Contributor Author

Don't worry! It's not an urgent PR. Thanks for responding

@wawanbreton
Copy link
Contributor

Hi @Pelochus, sorry I had to make a few commits to your mainbranch because we had updated the file on our side in the meantine, and it generated some conflicts.
Thanks for your contribution, it will be included in Cura 5.6 !

@wawanbreton wawanbreton merged commit 7ad35fa into Ultimaker:main Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Translations 📚 A PR that introduces or adjusts translation files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants