Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tech debt related to path prefix usages #334

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

keithkennedyHO
Copy link
Contributor

Removed tech debt related to path prefix usages.
Path prefix is no longer required due to the site being hosted at the root of the engineering.homeoffice.gov.uk domain

Code change

I can confirm:

Accessibility considerations

  • This change will not change layouts, page structures or anything else that might impact accessibility

@keithkennedyHO keithkennedyHO linked an issue Nov 3, 2023 that may be closed by this pull request
@keithkennedyHO keithkennedyHO marked this pull request as ready for review November 3, 2023 11:13
@keithkennedyHO keithkennedyHO requested a review from a team as a code owner November 3, 2023 11:13
@keithkennedyHO keithkennedyHO merged commit 9527809 into main Nov 7, 2023
2 checks passed
@keithkennedyHO keithkennedyHO deleted the 287-remove-_pathprefix-tech-debt branch November 7, 2023 11:34
keithkennedyHO added a commit that referenced this pull request Nov 7, 2023
…e principle/standard listing page (#335)

* Added related links for writing a principle/standard to the respective principle/standard listing page

* Removed tech debt related to path prefix usages (#334)

* Removed path prefix usages

* Removed test path prefix for e2e workflow

* Removed tag page logic used to work around path prefix issue

* Added related links for writing a principle/standard to the respective principle/standard listing page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACP-migration Relating to moving the repo to ukhomeoffice and ACP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _pathPrefix tech debt
3 participants