Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added related links for writing a principle/standard to the respective principle/standard listing page #335

Conversation

keithkennedyHO
Copy link
Contributor

Added related links for writing a principle/standard to the respective principle/standard listing page

Code change

I can confirm:

Accessibility considerations

  • This change will not change layouts, page structures or anything else that might impact accessibility

@keithkennedyHO
Copy link
Contributor Author

I believe issue with e2e tests will be resolved once #334 is merged. These links do not work with pathPrefix which is in place at the time of the test failure.

@keithkennedyHO keithkennedyHO marked this pull request as draft November 3, 2023 14:14
* Removed path prefix usages

* Removed test path prefix for e2e workflow

* Removed tag page logic used to work around path prefix issue
@edhamiltonHO
Copy link
Contributor

Now that #334 is in I think this branch will need to be rebased before tests will pass

…g-a-standardprinciple-on-the-respective-standardsprinciples-listing-pages' into 272-add-related-links-for-writing-a-standardprinciple-on-the-respective-standardsprinciples-listing-pages
@keithkennedyHO keithkennedyHO marked this pull request as ready for review November 7, 2023 12:28
@keithkennedyHO keithkennedyHO merged commit 8c75716 into main Nov 7, 2023
2 checks passed
@keithkennedyHO keithkennedyHO deleted the 272-add-related-links-for-writing-a-standardprinciple-on-the-respective-standardsprinciples-listing-pages branch November 7, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add related links for writing a standard/principle on the respective standards/principles listing pages
4 participants