Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) (HCT, HP, Covid): Use concept keys from the schema for better configurability. #1863

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

hadijahkyampeire
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire commented Jun 11, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

  • Used config schema keys in our tab jsons to ensure better configurability.
  • Implement a reusable function that maps configSchema values to json respective keys.
  • This covers the hct, hp and covid apps.
  • Removed duplicate concept uuids those they had different names.
  • Add new concepts for color statuses which were initially defined in specific components.

Screenshots

Related Issue

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hadijahkyampeire , the only pending thing, is to provide a way to edit the concept values and uuids from the implementer tools

@hadijahkyampeire
Copy link
Contributor Author

@CynthiaKamau we need to see if that is possible.

@hadijahkyampeire hadijahkyampeire merged commit 82ff232 into dev Jun 13, 2024
5 checks passed
@hadijahkyampeire hadijahkyampeire deleted the hk-use-schema-keys-hct-hp-covid branch June 13, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants