-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting PrEP usage #204
Starting PrEP usage #204
Conversation
…sted to start PrEP.
@andrew-phillips-1
What I'm confused about is that it appears to be modelling false negatives using a random variable, but don't false negatives already appear in the diagnosis part of the simulation? If we test all the HIV+ people who are selected for testing in a given time step, then the people who get diagnosed will be true positives, and the people who don't will be false negatives. Why is this code separate, is it modelling something different? Can this lead to people who are e.g. HIV+, get tested, get a (false) negative result, and still don't meet the criterion Is this modelling a separate round of testing i.e. testing before starting prep separately (and possibly in addition to) other forms of testing? (Although it doesn't appear to lead to diagnosis?) |
Thanks @mmcleod89 @pineapple-cat I will try to have a think about this before our call tomorrow. I've also let Jenny and Loveleen know. |
I think @mmcleod89 @pineapple-cat that this code is because the person has just tested in this period so we have not had a chance to get to the diagnosis part of the code. So for this test we need to consider that it could be a false negative before PrEP can be started. (The fact that we are not using the same random draw when lower down we are seeing whether the person is diagnosed is not quite right though I think and it would be good to have that working in Python version.) Am I misunderstanding ? |
# FIXME: this function may be removed if there are no issues with | ||
# updating PrEP after HIV diagnosis during population evolution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finding this out would include testing multiple modules together; where would it make the most sense to put this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question; and it's tricky to say right now because we're not sure what we would need to test yet to be able to figure this out. It might be possible to define some integration tests in a file of their own if we can say definitively what some behaviour of the simulation as a whole should look like when working together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We will need to look into updating CI to fix the test issue
Addresses #205.