Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using reflection for all of the string attributes by default #463

Open
muratcorlu opened this issue Mar 2, 2023 · 0 comments
Open

Using reflection for all of the string attributes by default #463

muratcorlu opened this issue Mar 2, 2023 · 0 comments
Labels
react Issues related with React wrapper

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Mar 2, 2023

We use reflect: true for the component properties those we use in our style definitions, to be sure their existence even if they are set as javascript property. But this doesn't cover external styling requirements. For example, in React:

<BlButton type="submit" />
bl-button[type=submit] {
	margin-top: 25px;
}

doesn't work. Because React always sets DOM properties and type property is not reflected in our button component.

Since we are not able to determine which attributes can be needed for attribute selection, one idea can be to set reflect: true by-default for all of our attributes.

Related: #299

@muratcorlu muratcorlu added the react Issues related with React wrapper label Mar 2, 2023
@muratcorlu muratcorlu added this to the 2023 Q2 milestone Mar 28, 2023
@muratcorlu muratcorlu modified the milestones: 2023 Q2, 2023 Q3 Jul 14, 2023
@leventozen leventozen removed this from the 2023 Q3 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react Issues related with React wrapper
Projects
Status: Selected
Development

No branches or pull requests

2 participants