Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Select placeholder not shown #719

Closed
1 task
AykutSarac opened this issue Sep 29, 2023 · 4 comments · Fixed by #720
Closed
1 task

[BUG]: Select placeholder not shown #719

AykutSarac opened this issue Sep 29, 2023 · 4 comments · Fixed by #720
Assignees
@muratcorlu
Labels
bl-select Select Component bug Something isn't working released on @beta released

Comments

@AykutSarac
Copy link
Member

Issue description

After upgrading from 2.3.0-beta.4 to 2.3.0-beta.5 Select's placeholder no longer visible.

Media & Screenshots

image image

Baklava Version

2.3.0-beta.5

Operating system

  • OS: [e.g. iOS]:

  • Browser [e.g. chrome, safari]:

  • Any other details...

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@AykutSarac AykutSarac added the bug Something isn't working label Sep 29, 2023
@muratcorlu
Copy link
Contributor

Oh, my bad. This should be related with auto width work that I have done #706 . I'll have a look.

@muratcorlu muratcorlu self-assigned this Sep 29, 2023
@muratcorlu muratcorlu moved this from Selected to In Development in Baklava Design System Sep 29, 2023
@muratcorlu muratcorlu added the bl-select Select Component label Sep 29, 2023
@muratcorlu muratcorlu linked a pull request Sep 29, 2023 that will close this issue
fix(select): reflection added for proper styling #720
Merged
This was referenced Sep 29, 2023
Merged
Open
@muratcorlu
Copy link
Contributor

It would be great to address those issues with a more generic solution like we mentioned in #299 and #463

@github-project-automation github-project-automation bot moved this from In Development to Done in Baklava Design System Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🎉 This issue has been resolved in version 2.3.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muratcorlu muratcorlu

Labels
bl-select Select Component bug Something isn't working released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): reflection added for proper styling Trendyol/baklava
2 participants
@muratcorlu @AykutSarac