Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detect missing reflection for attributes used in CSS #299

Open
muratcorlu opened this issue Oct 19, 2022 · 2 comments
Open

Auto-detect missing reflection for attributes used in CSS #299

muratcorlu opened this issue Oct 19, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Oct 19, 2022 •
edited
Loading

When we use a property of the component as a selector in its CSS, that property needs to be reflected. Otherwise we may have issues like #295

I imagine that can be checked with a linter rule or something. If it finds a selector like :host(*[{attrName}]*) and if that attribute doesn't have reflect: true then it can rise an error.

Related: #463
@leventozen leventozen added the enhancement New feature or request label Oct 19, 2022
@muratcorlu
Copy link
Contributor Author

Same problem reported in #378

@muratcorlu muratcorlu moved this to Selected in Baklava Design System Jan 19, 2023
@muratcorlu muratcorlu added this to the 2023 Q2 milestone Mar 28, 2023
@muratcorlu muratcorlu modified the milestones: 2023 Q2, 2023 Q3 Jul 14, 2023
@muratcorlu
Copy link
Contributor Author

Again we had another issue related with this #719

This was referenced Sep 29, 2023
Open
Closed
@leventozen leventozen removed this from the 2023 Q3 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Baklava Design System
Status: Selected
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muratcorlu @leventozen